Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite of Release Tutorial #435

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Rewrite of Release Tutorial #435

merged 2 commits into from
Sep 23, 2024

Conversation

FFHener
Copy link
Contributor

@FFHener FFHener commented Jul 16, 2024

Compile tested: no
Run tested: no

Description of your changes:
Rewrote the tutorial and removed one variable as dicussed in freifunk-berlin/meta#91

@FFHener FFHener requested review from Akira25 and pktpls July 16, 2024 16:11
@Akira25
Copy link
Member

Akira25 commented Sep 23, 2024

Thank you for the contribution! Sorry, that I let the MR lay around for so long.

For the content: You gave a nice description of how to build a release. From an organisational point of view, I'd love to have the pre-release somehow codified in the document.

We always do a public pre-release, inviting the community to test with us. This serves different functions:

  • When others were invited to test with us, it gets socially difficult to blame us for testing not enough
  • In the past, the community actually found bugs, which we didn't find, i.e. because we didn't had the hardware

Therefore I'd love to have the pre-release mentioned in the tutorial.

@FFHener
Copy link
Contributor Author

FFHener commented Sep 23, 2024

The checks fail due to deprecated dependencies. I opened an Issue for this #439

@Akira25
Copy link
Member

Akira25 commented Sep 23, 2024

@FFHener I rebased this on the current main, thus the ci should be fixed.

@Akira25 Akira25 merged commit a4ade81 into main Sep 23, 2024
7 checks passed
@FFHener FFHener deleted the making-a-release branch September 23, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants