Skip to content

Commit

Permalink
luci-app-acme: Remove use_acme_server option since it's ignored by acme
Browse files Browse the repository at this point in the history
In the 1ad72c6 was added use_acme_server flag and acme_server URL.
The problem is that the acme uses the only acme_server option.
A user may think that once the flag is turned off it will be ignored, but it's not.

To avoid confusion, it's easier just to remove the flag.

Signed-off-by: Sergey Ponomarev <[email protected]>
  • Loading branch information
stokito authored and tohojo committed May 26, 2024
1 parent 31ba396 commit fcc4cc9
Showing 1 changed file with 2 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -505,15 +505,9 @@ return view.extend({
uci.set('acme', section_id, 'key_type', value);
};

o = s.taboption('advanced', form.Flag, "use_acme_server",
_("Custom ACME CA"), _("Use a custom CA instead of Let's Encrypt."));
o.depends("staging", "0");
o.default = false;
o.modalonly = true;

o = s.taboption('advanced', form.Value, "acme_server", _("ACME server URL"),
_("Custom ACME server directory URL."));
o.depends("use_acme_server", "1");
_('Use a custom CA instead of Let\'s Encrypt.') + ' ' + _('Custom ACME server directory URL.'));
o.depends("staging", "0");
o.placeholder = "https://api.buypass.com/acme/directory";
o.optional = true;
o.modalonly = true;
Expand Down

0 comments on commit fcc4cc9

Please sign in to comment.