Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network (Uplink): Implement option "dhcp_client" #1148

Closed

Conversation

LipkeGu
Copy link

@LipkeGu LipkeGu commented Dec 28, 2024

This PR implements on "corerouter" the option "dhcp_client" as bool on uplink and sets proto: dhcp. The option is documented and by default disabled and not set to keep the current behavier of the devices.

Example locations/(###my_example_location###.yml):

  - vid: 50
    role: uplink
    dhcp_client: false

Current:

config interface 'uplink'
	option device 'br-uplink'
	option proto 'none'

Result:

config interface 'uplink'
	option device 'br-uplink'
	option proto 'dhcp'

Maybe helpfully in issue: #1045

@LipkeGu LipkeGu force-pushed the uplink_option_dhcp_client- branch from c5ae4f6 to 3b2f0ba Compare December 28, 2024 00:43
@LipkeGu LipkeGu changed the title Network (Uplink): Implement bool "dhcp_client" Network (Uplink): Implement option "dhcp_client" Dec 28, 2024
@LipkeGu LipkeGu changed the title Network (Uplink): Implement option "dhcp_client" Network (Corerouter->Uplink): Implement option "dhcp_client" Dec 28, 2024
@LipkeGu LipkeGu changed the title Network (Corerouter->Uplink): Implement option "dhcp_client" Network (Uplink): Implement option "dhcp_client" Dec 28, 2024
@LipkeGu LipkeGu changed the title Network (Uplink): Implement option "dhcp_client" Network (Uplink): Implement option "dhcp_client" for br-uplink Dec 28, 2024
@LipkeGu LipkeGu changed the title Network (Uplink): Implement option "dhcp_client" for br-uplink Network (Uplink): Implement option "dhcp_client" Dec 28, 2024
@LipkeGu LipkeGu closed this Jan 2, 2025
@LipkeGu LipkeGu reopened this Jan 2, 2025
@LipkeGu LipkeGu closed this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant