Improve generate-images & mass-update script and readme #1146
+174
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noki
force-pushed
the
improve-scripts
branch
2 times, most recently
from
4c492be to
fb32311
Compare
Noki
changed the title
Noki
force-pushed
the
improve-scripts
branch
4 times, most recently
from
5e6d394 to
e800a06
Compare
- query locations and hosts with yq - allow passing locations as comma separated list - skip invalid locations
- add support for x86 images - get role (corerouter, gateway, ap) from yml files instead of user "-core" from filename - make availability support IPv4 and IPv6
pktpls
force-pushed
the
improve-scripts
branch
from
e800a06 to
dfae3d6
Compare
pktpls
reviewed
Jan 3, 2025
| mapfile -t locations < <(yq '.location' locations/*.yml | sed 's/\"//g' | sort) | ||
|
|
||
| # Extract valid hosts | ||
| mapfile -t hosts < <(yq '.hosts[] | select(.role == "corerouter" or .role == "gateway" or .role == "ap") | .hostname' locations/*.yml | sed 's/\"//g' | sort) |
There was a problem hiding this comment.
You can use yq -r instead of the sed call: "-r output raw strings, not JSON texts"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.