Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pktplsmobil: init location #1113

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

pktpls
Copy link
Contributor

@pktpls pktpls commented Dec 10, 2024

No description provided.

@pktpls
Copy link
Contributor Author

pktpls commented Dec 10, 2024

This integrated LTE modem is a little different from usual LTE modems on a USB stick. It needs to be configured over CDC-WDM, including the provider-specific APN and PDPType options. In addition it can't have a macvlan bridge around it, which is why we use tunspace's direct mode.

@pktpls
Copy link
Contributor Author

pktpls commented Dec 10, 2024

Error: /workspace/group_vars/model_glinet_gl_xe300.yml:8:25: [error] too few spaces after comma (commas)

Nice one 💯

# assignments:
# pktplsmobil-core: 1

- vid: 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean 41?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I think this is on purpose, the switch is a little weird. I'll check to make sure what I was doing there

Comment on lines +72 to +100
location__wireless_profiles__to_merge:
- name: pktplsmobil
devices:
- radio: 11g_standard
legacy_rates: false
country: DE
ifaces:
- mode: ap
ssid: berlin.freifunk.net
encryption: none
network: dhcp
radio: [11g_standard]
ifname_hint: ff
owe_transition_ifname_hint: ffowe
- mode: ap
ssid: berlin.freifunk.net OWE
hidden: true
encryption: owe
network: dhcp
radio: [11g_standard]
ifname_hint: ffowe
owe_transition_ifname_hint: ff
ieee80211w: 2
- mode: mesh
mesh_id: Mesh-Freifunk-Berlin
radio: [11g_standard]
mcast_rate: 12000
mesh_fwding: 0
ifname_hint: mesh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference to the normal profile? Or do you just want to have this to change options for testing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 11a_standard radio doesn't exist, this device is 2.4 GHz only. But I think the templates should actually handle that fine...

Comment on lines +88 to +96
{% if 'wwan' in network %}
config interface 'wwan'
{% set wwan = network['wwan'] %}
option proto '{{ wwan['proto'] }}'
option device '{{ wwan['device'] }}'
option apn '{{ wwan['apn'] }}'
option pdptype '{{ wwan['pdptype'] }}'
{% endif %}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be nice to document this in the DEVELOPER.md as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants