Skip to content

Commit

Permalink
workflows: added missing mac_override check
Browse files Browse the repository at this point in the history
  • Loading branch information
Noki committed Aug 17, 2024
1 parent 2e0b025 commit 1a3b679
Show file tree
Hide file tree
Showing 2 changed files with 74 additions and 0 deletions.
57 changes: 57 additions & 0 deletions .github/checks/check-mac-overrides.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
#!/bin/bash

# Initialize a variable to track if any errors are found
error_found=0

# Get the list of changed .yml files in the locations directory compared to the main branch
changed_files=$(git diff --name-only main...HEAD | grep '^locations/.*\.yml$')

# Check if there are no changes in .yml files in the locations directory
if [ -z "$changed_files" ]; then
echo "No changes in .yml files within the locations directory."
exit 0
fi

# Loop through all changed location YAML files
for location_file in $changed_files; do
echo "Processing $location_file"

# Extract host information using yq
host_count=$(yq '.hosts | length' "$location_file")

# Loop through each host entry
for ((i=0; i<$host_count; i++)); do
hostname=$(yq ".hosts[$i].hostname" "$location_file")
model=$(yq ".hosts[$i].model" "$location_file")
mac_override=$(yq ".hosts[$i].mac_override" "$location_file")

# Convert model name to match the model file format
model_file=$(echo "$model" | sed 's/-/_/g' | sed 's/"//g')
model_file_path="group_vars/model_${model_file}.yml"

# Check if the model file exists
if [ ! -f "$model_file_path" ]; then
echo "Error: Model file $model_file_path not found for host $hostname with model $model"
error_found=1
continue
fi

# Check if the model requires mac_override
requires_mac_override=$(yq '.requires_mac_override' "$model_file_path")

if [ "$requires_mac_override" = "true" ]; then
if [ "$mac_override" == "null" ]; then
# Output the missing mac_override details immediately
echo "Error: Host $hostname (model: $model) in $location_file is missing mac_override."
error_found=1
fi
fi
done
done

# Exit with a non-zero status code if any errors were found
if [ "$error_found" -eq 1 ]; then
exit 1
else
echo "MAC override check completed successfully."
fi
17 changes: 17 additions & 0 deletions .github/workflows/check-mac-overrides.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
---
name: Check mac_overrides

on: [push, pull_request] # yamllint disable-line rule:truthy

jobs:
mac_override_check:
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Run mac_override check
run: |
./.github/checks/check-mac-overrides.sh

0 comments on commit 1a3b679

Please sign in to comment.