Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates 'n' stuff #108

Merged
merged 9 commits into from
Jan 14, 2024
Merged

Updates 'n' stuff #108

merged 9 commits into from
Jan 14, 2024

Conversation

nicolasberens
Copy link
Contributor

A bunch of fixes:

  • Encrypt variables, not files #71 encrypt only secret vars not files
  • limit access to prometheus exporter #105 only allow access to prometheus_exporter from localhost, the ff network and the monitoring server
  • add smaller fixes for the monitoring server
  • divide common role into simpler files
  • add logrotate for the most common logs with more restrictive defaults
    • keep one logfile per day
    • only store data for 14 days

@Akira25
Copy link
Member

Akira25 commented Jan 12, 2024

In overall, this looks good to me.

Akira25
Akira25 approved these changes Jan 14, 2024
View reviewed changes
Copy link
Member

@Akira25 Akira25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nicolasberens nicolasberens merged commit 40a7d52 into main Jan 14, 2024
5 checks passed
@FFHener
Copy link

FFHener commented Feb 1, 2024

Can I close the 2 linked Issues and delete the updates branch?

@FFHener FFHener deleted the updates branch February 2, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akira25 Akira25 Akira25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolasberens @Akira25 @FFHener