Invokes onChange()
handler of DigitsInput
component with null
when input value is NaN
#19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 概要
DigitsInput
は内部で数字への parse に失敗したときにNaN
とともにonChange()
handler が呼び出される.そのため利用側で
NaN
を考慮したロジックを実装する必要が出てくる.本来
DigitsInput
ではNaN
を取り扱うことは想定していないはずなので,Number.isFinite()
を使って parse された値が有限数であるか check を行い, 有限数であれば parse された値, そうではない場合はnull
とともにonChange()
を呼び出すように修正した.😛 やってないこと
✔️ 動作確認