Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set status to ONLINE_WITH_OTHER_APP when receiving messages from unknown clients #105

Merged
merged 2 commits into from
Mar 3, 2015

Conversation

dborkan
Copy link
Contributor

@dborkan dborkan commented Mar 3, 2015

Fixes UWNetworksLab/uProxy-p2p#892

Tested with updated grunt test.

// onClientState events without any status field.
// See https://github.com/uProxy/uproxy/issues/892 for more info.
// TODO: periodically re-sync the roster so we don't keep this client
// ONLINE_WITH_OTHER_APP forever.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mention tracking in #107

@willscott
Copy link
Member

minor comment change, then 👍

dborkan added a commit that referenced this pull request Mar 3, 2015
Set status to ONLINE_WITH_OTHER_APP when receiving messages from unknown clients
@dborkan dborkan merged commit 784971a into master Mar 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onClientState missing status field (firewall error)
2 participants