Load all pages of Facebook friends #30
Conversation
| } | ||
| var xhr = new XMLHttpRequest(); | ||
| xhr.open('GET', url); | ||
| var thisFacebookSocialProvider = this; |
There was a problem hiding this comment.
thisFacebookSocialProvider is used within the xhr.onload callback. Within that callback, just using this won't give us what we want, and if we do the usual .bind(this) we won't be able to easily access this.response returned by the XHR
|
What does it mean to change the LIMIT to 2? could we have changed the LIMIT to 5000 and that would've fixed it? |
|
I have about 10 FB friends who use uProxy. Changing the LIMIT to 2 for testing means that it ensures that the loadContacts_ method is called recursively. If I used LIMIT=100, all the contacts would be loaded after the first XHR request. We could change the limit to 5000 but at some point it could be slow, and it's not clear what limits might exist on Facebook's side. For now 100 seems like a safe option. |
|
Closing this - we no longer load the users Facebook friends in freedom-social-firebase, but instead friends are added via invites |
Fixes #11
Tested in Chrome (by changing LIMIT to 2 and verifying that it successfully made the recursive calls to get all pages of friends).