Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github Actions CI (bp #75) #78

Open
wants to merge 1 commit into
base: 1.2.x
Choose a base branch
from
Open

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Dec 1, 2020

This is an automated backport of pull request #75 done by Mergify

Cherry-pick of 4b5f5ae has failed:

On branch mergify/bp/1.2.x/pr-75
Your branch is up to date with 'origin/1.2.x'.

You are currently cherry-picking commit 4b5f5ae.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)

	deleted by us:   .github/workflows/test.yml

no changes added to commit (use "git add" and/or "git commit -a")

To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

(cherry picked from commit 4b5f5ae)

# Conflicts:
#	.github/workflows/test.yml
@mergify mergify bot added the conflicts label Dec 1, 2020
@mergify mergify bot mentioned this pull request Dec 1, 2020
@mergify mergify bot added the Backport Automated backport, please consider for minor release label Dec 1, 2020
@jackkoenig jackkoenig changed the title Simplify Github Actions CI (bp #75) Add Github Actions CI (bp #75) Dec 1, 2020
@jackkoenig
Copy link
Contributor

@chick 1.2.x didn't have CI so Mergify/git was kind enough to turn this backport into just adding CI 🙂

@jackkoenig
Copy link
Contributor

@chick a few tests fail with errors like:

[info] HierarchicalModulesExample:
[info] - This is an example of a module with hierarchical submodules  *** FAILED ***
[info]   java.io.IOException: Cannot run program "xdg-open": error=2, No such file or directory

Why isn't this an issue on 1.3.x?

@chick
Copy link
Contributor

chick commented Dec 1, 2020

@jackkoenig It's a complete mystery, I'm trying to track this down now. xdg-open is mentioned only in one unused function in FirrtlDiagrammer object. I'm looking for clues still

@chick
Copy link
Contributor

chick commented Dec 17, 2020

I thought this would be fixed by PR #80 which forced the diagram open program to "" for the tests.
But CI still fails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport Automated backport, please consider for minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants