Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: heatmap for Customer and Supplier not rendering #44717

Open
wants to merge 1 commit into
base: version-14-hotfix
Choose a base branch
from

Conversation

FHenry
Copy link
Contributor

@FHenry FHenry commented Dec 16, 2024

Please provide enough information so that others can review your pull request:

In version-14 there is a heatmap on Customer and Supplier dashboard.

Since this commit 2a5f663

the get_timeline_data attribute use by frappe.desk.notifications.get_open_count() was remove so the heatmap is always empty

These heatmap are not more displayed in version-15 for Customer and Supplier, so it's only a matter on version-14

Explain the details for making this change. What existing problem does the pull request solve?

Add get_timeline_data in import to allow frappe.desk.notifications.get_open_count() provide heatmap

Screenshots/GIFs
Before:
image

After:
image

no-docs

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant