fix: validate advance amount in company currency #44693
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
accounts
needs-tests
venkat102
requested review from
ruthra-kumar and
rohitwaghchaure
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Unable to create purchase invoice with the advance amount in foreign currency due to minor precision loss
ref: 26967
Payment:
Invoice:
Error:
invoice amount - 80.445
exchange rate - 0.104950000
80.445/0.104950000 = 766.5078608861362
766.5078608861362 * 0.104950000 = 80.445
but since it is being rounded with field precision 766.50 * 0.104950000 = 80.444175
so the condition 80.445 > 80.444175 is passed
Backport needed for v15