Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check difference_posting_date #44653

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

venkat102
Copy link
Contributor

Issue:
Exchange gain/loss journal posting on the current date instead of the invoice date
ref: 26926

Payment Entry:
image

Purchase Invoice:
image

Exchange Journal Before:
image

Exchange Journal After:
image

Backport needed v14 &v15

@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. labels Dec 11, 2024
@ruthra-kumar
Copy link
Member

@venkat102
Have you checked below configuration?
Screenshot 2024-12-11 at 1 55 50 PM

@venkat102
Copy link
Contributor Author

@venkat102 Have you checked below configuration? Screenshot 2024-12-11 at 1 55 50 PM

@ruthra-kumar here the advance is not maintained in the separate account, so book_advance_payments_in_separate_party_account is not enabled

also the issue is raised on v14, I think, in v14 we doesn't have this feature

@venkat102 venkat102 marked this pull request as ready for review December 11, 2024 10:28
@ruthra-kumar ruthra-kumar self-assigned this Dec 13, 2024
@ruthra-kumar
Copy link
Member

ruthra-kumar commented Dec 17, 2024

@venkat102

Even with this change posting date of Exchange Gain / Loss journal will still be on the reconciliation date. This is because args will always have 'difference_posting_date' set from the allocation table on Reconciliation tool.

Screenshot from 2024-12-17 16-55-50

This behavior is intentional as users wanted more control on the posting date of Exchange Gain / Loss journals. A better solution will be to replicate the config setup in v15(like this) on v14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accounts needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants