fix: added precision validation #43979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khushi8112
added
backport version-15-hotfix
and removed
needs-tests
khushi8112
added a commit
that referenced
this pull request
Nov 5, 2024
…-43979 fix: added precision validation (backport #43979)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
This fix addresses an issue where row.expected_value_after_useful_life was triggering a condition due to minor decimal differences, even when the values should logically be considered equal. Since row.expected_value_after_useful_life is not adjusted for precision.
Solution:
To resolve this, we will apply consistent precision to row.expected_value_after_useful_life and asset_value_after_full_schedule before performing the comparison.