fix: calculate tds with net amount when invoice exceeds single threshold amount (backport #43869) #43919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
mergify
bot
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
frappe-pr-bot
pushed a commit
that referenced
this pull request
Oct 30, 2024
## [14.74.8](v14.74.7...v14.74.8) (2024-10-30) ### Bug Fixes * add company filter for project ([d3e29fe](d3e29fe)) * add parenttype clause to invoice tax query in sales_register report ([cbe704c](cbe704c)) * added validation for UOM must be whole number (backport [#43710](#43710)) ([#43711](#43711)) ([aaae81f](aaae81f)) * basic rate not editable in Stock Entry Detail (backport [#43837](#43837)) ([#43839](#43839)) ([51c1d03](51c1d03)) * calculate tds with net amount when invoice exceeds single threshold amount (backport [#43869](#43869)) ([#43919](#43919)) ([55c5f30](55c5f30)) * do not check for payment terms details for return invoices. ([fd63ace](fd63ace)) * do not set payment terms for return invoices ([bd34a67](bd34a67)) * get stock accounts from the doc instead of db in validate_stock_accounts ([ad04610](ad04610)) * hide payment terms for return and paid purchase invoices ([78db8c0](78db8c0)) * not able to submit stock entry ([#43890](#43890)) ([0742e6e](0742e6e)) * purchase return validation issue ([#43871](#43871)) ([a7cc7b2](a7cc7b2)) * remarks field in payment reconciliation ([93243b1](93243b1)) * **RFQ:** make strings translatable (backport [#43843](#43843)) ([#43847](#43847)) ([895f1bf](895f1bf)) * set bill_no before `against_voucher` gets concatenated ([2f3c3d5](2f3c3d5)) * work order finish button not showing (backport [#43875](#43875)) ([#43877](#43877)) ([76530de](76530de))
|
🎉 This PR is included in version 14.74.8 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When a purchase invoice exceeds the single threshold value but doesn't exceed the cumulative threshold, the TDS amount is calculated on the grand total instead of the net total when consider_party_ledger_amount is ticked on Tax Withholding Category
ref: 23540
Before:
TDS Calculation Issue
After:
TDS Calculation Fix
Backport needed: v14 & v15
This is an automatic backport of pull request #43869 done by Mergify.