fix: map rows on journal entry by validating account, party, debit and credit value #43226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Navin-S-R
requested review from
deepeshgarg007,
rohitwaghchaure and
ruthra-kumar
as code owners
erpnext/accounts/doctype/payment_reconciliation/test_payment_reconciliation.py
Outdated
Show resolved
Hide resolved
erpnext/accounts/doctype/payment_reconciliation/test_payment_reconciliation.py
Outdated
Show resolved
Hide resolved
erpnext/accounts/doctype/payment_reconciliation/test_payment_reconciliation.py
Outdated
Show resolved
Hide resolved
erpnext/accounts/doctype/payment_reconciliation/test_payment_reconciliation.py
Outdated
Show resolved
Hide resolved
erpnext/accounts/doctype/payment_reconciliation/test_payment_reconciliation.py
Outdated
Show resolved
Hide resolved
Navin-S-R
commented
Sep 17, 2024
erpnext/accounts/doctype/payment_reconciliation/test_payment_reconciliation.py
Show resolved
Hide resolved
ruthra-kumar
added a commit
that referenced
this pull request
Sep 17, 2024
…-43226 fix: map rows on journal entry by validating account, party, debit and credit value (backport #43226)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Unable to reconcile payment journal entry from closed fiscal year
https://support.frappe.io/helpdesk/tickets/21665
Before:
After:
backport needed for v15