fix(ux): set amount on foreign currency when foreign currency account… #43224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is selected on last row of journal
venkat102
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
ruthra-kumar
approved these changes
Sep 16, 2024
ruthra-kumar
added a commit
that referenced
this pull request
Sep 16, 2024
…-43224 fix(ux): set amount on foreign currency when foreign currency account… (backport #43224)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
While creating the journal entry on foreign currency, a new row sets the amount in company currency
https://support.frappe.io/helpdesk/tickets/21605
Before:
https://github.com/user-attachments/assets/5fb009ce-678f-475f-8ad3-0952e6064031
After:
https://github.com/user-attachments/assets/986ccba7-e8ed-4e65-96c6-8ba3953de582
backport needed for v15