fix: get cost center allocation percentage only from the applicable allocation #43216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venkat102
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
ruthra-kumar
approved these changes
Sep 18, 2024
ruthra-kumar
added
backport version-14-hotfix
ruthra-kumar
added a commit
that referenced
this pull request
Sep 18, 2024
…-43216 fix: get cost center allocation percentage only from the applicable allocation (backport #43216)
ruthra-kumar
added a commit
that referenced
this pull request
Sep 18, 2024
…-43216 fix: get cost center allocation percentage only from the applicable allocation (backport #43216)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
sub cost center and percentage not fetching properly from Cost Center Allocation, when there are multiple allocation entries with different sets of sub cost centers
https://support.frappe.io/helpdesk/tickets/21870
Before:
https://github.com/user-attachments/assets/16f3a55b-4f4f-4e79-884c-a2e14ccca093
After:
https://github.com/user-attachments/assets/d275aca0-608b-4162-954c-6703ea2cf2e0
backport needed for v14 and v15