Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Payment Ledger Report currency fieldtype fix #43213

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

sameer55chauhan
Copy link
Contributor

In the Payment Ledger Report "currency" field has the wrong fieldtype. As per the incoming data, it should be a Link field.

image

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 13, 2024
@ruthra-kumar ruthra-kumar removed the request for review from deepeshgarg007 September 16, 2024 03:48
@ruthra-kumar ruthra-kumar self-assigned this Sep 16, 2024
@ruthra-kumar
Copy link
Member

@sameer55chauhan
Could you let us know the issue and how this change can fix it?

@sameer55chauhan
Copy link
Contributor Author

@sameer55chauhan Could you let us know the issue and how this change can fix it?

Okay! Let's suppose that it is visible on the UI in ERP, this is how it would look like: (showing 0 in all cases which is somewhat wrong display of information)
Screenshot 2024-09-17 173404
With the fix it would look like this: (showing all the currencies)
Screenshot 2024-09-17 173455

Second, What is the need for this fix as the currency is hidden from the user?
The answer is we are working on a custom frontend-based solution, where we are getting the report from ERP as well as the metadata and rendering it. But with the current currency field, it shows NaN, although we can handle it and show 0 that would be incorrect information.
image

@ruthra-kumar ruthra-kumar merged commit 34d159b into frappe:version-15-hotfix Sep 19, 2024
12 checks passed
ruthra-kumar added a commit that referenced this pull request Sep 19, 2024
…-43213

fix: Payment Ledger Report currency fieldtype fix (backport #43213)
@ruthra-kumar
Copy link
Member

@mergify copy develop

Copy link
Contributor

mergify bot commented Sep 19, 2024

copy develop

✅ Pull request copies have been created

ruthra-kumar added a commit that referenced this pull request Sep 19, 2024
fix: Payment Ledger Report currency fieldtype fix (copy #43213)
@sameer55chauhan sameer55chauhan deleted the patch-4 branch September 19, 2024 05:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants