fix: delete exchange gain loss journal entry while deleting payment entry (backport #43191) #43201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
mergify
bot
requested review from
deepeshgarg007,
rohitwaghchaure and
ruthra-kumar
as code owners
|
🎉 This PR is included in version 14.74.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: while deleting the payment entry in foreign currency if it has exchange gain loss journal entry against it. Its not getting deleted.
https://support.frappe.io/helpdesk/tickets/20300
Before:
https://github.com/user-attachments/assets/92a6e320-2764-4ed5-a714-4b9083cdf25e
After:
https://github.com/user-attachments/assets/ae065d99-c42c-4c7b-861c-6785015f4558
backport needed for v15
This is an automatic backport of pull request #43191 done by Mergify.