Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refine GLE deletion with against voucher check #43194

Conversation

khushi8112
Copy link
Member

@khushi8112 khushi8112 commented Sep 12, 2024

Issue:

  • A user was unable to delete an asset record, even after enabling the 'Delete Accounting and Stock Ledger Entries on Deletion of Transaction' option.
  • The error occurred because the asset was linked to the GL entry through the 'against voucher' field, with the voucher type being 'Journal Entry'.
  • The deletion logic was only validating the 'voucher type' but did not account for the 'against voucher' field, leading to the error.

Resolution:

  • Updated the deletion logic to also check the 'against voucher' field in addition to the 'voucher type'.

internal issue: 21449

@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. labels Sep 12, 2024
Copy link

stale bot commented Oct 5, 2024

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Oct 5, 2024
@khushi8112 khushi8112 closed this Oct 10, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants