Unizone mobile app #42422
Closed
Unizone mobile app #42422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aditya-skyai
commented
Jul 20, 2024
Aditya-skyai
commented
…kport frappe#31168) (frappe#31267) fix: Auto Insert Item Price If Missing when discount & blank UOM (frappe#31168) * fix: Auto Insert Item Price If Missing when discount and blank UOM fixes wrong item price insert when discount is used and adds uom=stock_uom instead of blank as price is converted to stock uom * unit tests added for item with discount I have added test for auto_insert_price where discount is used. * unit test issue fixed fixed make_sales_order as some of the test that depended on it were failing due to passing of incorrect parameters. Co-authored-by: Ankush Menat <[email protected]> (cherry picked from commit b3ccc4b) Co-authored-by: maharshivpatel <[email protected]>
…rappe#31247) (cherry picked from commit fb4f8d8)
- Utility to update cost in all BOMs without cron jobs or background jobs (run immediately) - Re-use util wherever all bom costs are to be updated - Skip explicit commits if in test - Specify company in test records (dirty data sometimes, company wh mismatch) - Skip background jobs queueing if in test
- Use base_rate for assertions as rate is subject to change due to conversion factor (USD)
- Use qb instead of db.sql - Don't use `args` as argument for function - Cleaner variable names
…ackport frappe#31282) (frappe#31283) fix: Use `frappe.as_unicode` to decode output of redis module list (frappe#31282) - As of redis 7, a list is added to the result of fetching the module list - This list cannot be "decoded",so use `frappe.as_unicode` that handles bytes as well as other types (cherry picked from commit 2832731) Co-authored-by: Marica <[email protected]>
…ta (update cost) - Remove `auto_commit_on_many_writes` in `update_cost_in_level()` as commits happen every N BOMs - Auto commit every 50 BOMs - test: Remove hacky `frappe.flags.in_test` returns - test: Enqueue `now` if in tests (for update cost and replace bom) - Replace BOM: Copy bom object to `_doc_before_save` so that version.py finds a difference between the two - Replace BOM: Add reference to version - Update Cost: Unset `processed_boms` if Log is completed (useless after completion) - test: `update_cost_in_all_boms_in_test` works close to actual prod implementation (only call Cron job manually) - Test: use `enqueue_replace_bom` so that test works closest to production behaviour Co-authored-by: Ankush Menat <[email protected]>
…rappe#31298) fix(ux): hide new version btn on unsaved BOM (frappe#31297) (cherry picked from commit d9a5213) Co-authored-by: Ankush Menat <[email protected]>
(cherry picked from commit bbaa14a)
Update ar.csv Fix Translation arabic translation that caused an error when submitting an asset if user language was arabic
perf: BOM Update Tool (backport)
…fix/pr-31296 fix: misaligned columns in print format of AR/AP report (backport frappe#31296)
* fix: update ru translate (frappe#31200) * Update ru.csv * Update ru.csv * Update ru.csv * Update ru.csv * Update ru.csv * Update ru.csv * Update ru.csv * Update ru.csv fix logic * Update ru.csv * Update ru.csv * Update ru.csv (cherry picked from commit 2675751) # Conflicts: # erpnext/translations/ru.csv * fix: Merge conflicts Co-authored-by: Vladislav <[email protected]> Co-authored-by: Marica <[email protected]>
…lier (backport frappe#31302) (frappe#31306) fix: Reset represents company on disabling internal customer and supplier (frappe#31302) (cherry picked from commit c13e5ad) Co-authored-by: Deepesh Garg <[email protected]>
(cherry picked from commit 48bde2d)
(cherry picked from commit b9dbb36)
(cherry picked from commit ee2949a)
…fix/pr-31216 fix: Trial Balance failing to ignore Finance Book (backport frappe#31216)
(cherry picked from commit 20f568c)
(cherry picked from commit 50aafdb)
In fieldtypes locale settings (example NL) . and , changes whereby the field is inproperly filled (cherry picked from commit 17887cd)
…fix/pr-31102 feat: Add german translations (backport frappe#31102)
…atch found error issue..
currency precision change by 2 in PO and PR
Aditya-skyai
requested review from
deepeshgarg007,
rohitwaghchaure,
s-aga-r and
ruthra-kumar
as code owners
github-actions
bot
added
accounts
assets
buying
CRM
ecommerce
HR
manufacturing
projects
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.