fix(Holiday List): sort holidays on save to avoid disorienting the user (backport #42236) #42251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
|
Cherry-pick of ad13725 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
ruchamahabal
reviewed
Jul 9, 2024
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
## [14.70.10](v14.70.9...v14.70.10) (2024-07-10) ### Bug Fixes * add missing german translations ([d5c1c62](d5c1c62)) * empty item-wise sales/purchase register reports on initial load ([13895fa](13895fa)) * fetch expence account from asset category ([4d6a71a](4d6a71a)) * group by in item-wise purchase register ([62ad466](62ad466)) * **Holiday List:** sort holidays on save to avoid disorienting the user (backport [#42236](#42236)) ([#42251](#42251)) ([fcf6500](fcf6500)) * manual pick allow to pick more than available stock (backport [#42155](#42155)) ([#42158](#42158)) ([454e147](454e147)) * multiple free items on same Item Group ([701dd9e](701dd9e)) * removed max discount validation for sales return ([4195c50](4195c50)) * stock qty validation in SCR (backport [#42124](#42124)) ([#42224](#42224)) ([e2f8e02](e2f8e02)) * tax on stock_rbnb on repost of Purchase Receipt ([106c154](106c154)) * **tds:** use doctype reference when mapping keys across multiple doctypes ([51cbbee](51cbbee)) * updated logic for calculating tax_withholding_net_total in payment entry ([49e5066](49e5066)) * use standard method to get `_doc_before_save` ([9fde733](9fde733))
|
🎉 This issue has been resolved in version 14.70.10 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the holidays table already has some weekly holidays and local holidays are added using the button, they get sorted even before saving. This might be disorienting for the user if they want to check and remove/change some local holidays. Append holidays at the end of the table and sort on save instead.
holiday-list.mp4
This is an automatic backport of pull request #42236 done by [Mergify](https://mergify.com).