fix: Force Fetching updates on Subscriptions

[ruthra-kumar]

Issue

Post this refactor, Fetch Subscription Updates creates Invoices only if the Current Invoice Start / End date matches the current date. For old subscriptions, this also resets these values to the current periods' start and end dates without creating any pending invoices.

Consider the below subscription,

Subscription Start Date	1st Jan
Subscription End Date	31 Dec
Plan Interval	1 Month

and current date is 2nd March

When 'Fetch Subscription Updates' is triggered,

Current behavior:

No Invoices are created for Jan and Feb and current_invoice_start and current_invoice_end date are updated to the latest month - March

Expected behavior:

Invoice for January should be created and the current_invoice_start and current_invoice_end should be updated to February. Upon triggering 'Fetch Subscription Updated' again, the same should happen for February. Triggering it again, should not create any invoices as the current period - March, is not over.

Fix

Adding a new Action button Force-Fetch Subscription Updates. This will have the expected behavior stated above, without allowing the scheduled job to create invoices for old subscriptions on its own.

Internal Ref: 13453

[david-loe]

I would love to see this merged!

[ruthra-kumar]

Backgroud Job

create_subscription_process runs every day. So, any old subscription with current_invoice_start and current_invoice_end still lower than current date will have it's Invoice created by the job and it will keep creating invoice daily till the current_invoice_start and current_invoice_end are within the current period.

This behavior is unwanted and was the reason for the original refactor in #30963

Maybe a different approach is required.

[ruthra-kumar]

Maybe a different approach is required.

A new action button Force-Fetch Subscription Updates is added to achieve the intended effect without affecting the background job behavior.

[david-loe]

some how the price of the resulting invoices is higher/lower than it should be, depending on the distance of the subscription period to the current date. A strange margin is added.

Start Date: 16th June
Interval: 1 Month
Price of Subscriotion: 80€

Create 2 Invoices with new force action

Invoice#1: 154,67€
Invoice#2: 72,26€