Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lpe): add discretionary reason #42135

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

blaggacao
Copy link
Collaborator

@blaggacao blaggacao commented Jul 1, 2024

Context

  • LP may be earned on discretionary terms implemented in a servers script outside of the calculation of the loyalty program

  • Eg Referral bonus on third party sales

  • Communication / Notification may need to be distinguishable as per the reason

Solution

  • Mark mandatory fields as such
  • Add reason field to capture nuances for messaging

no-docs

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jul 1, 2024
@blaggacao blaggacao changed the title feat(lpe): add distretionary reason feat(lpe): add discretionary reason Jul 2, 2024
@stale stale bot added inactive and removed inactive labels Aug 25, 2024
@frappe frappe deleted a comment from stale bot Sep 5, 2024
@blaggacao blaggacao merged commit c6e2470 into frappe:develop Sep 6, 2024
12 of 13 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2024
@blaggacao blaggacao deleted the feat/lpe-discretionary branch September 30, 2024 12:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant