-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: create Project from Template set Project Type and Start Date #41309
base: develop
Are you sure you want to change the base?
Conversation
Note to reviewer : I added tests after first commit, so label need-test is not accurate |
This comment has been minimized.
This comment has been minimized.
@deepeshgarg007 No reviewer auto-assign on this PR ? Could you have a look please ? |
This comment has been minimized.
This comment has been minimized.
@deepeshgarg007 No reviewer auto-assign on this PR ? Could you have a look please ? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hello Frappe Team, there are no "auto-reviewer" for this PR affected by default. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@barredterra, @s-aga-r |
Create Project Template of Project Type = Other
Create a Project from this template, Project Type is empty and start date is empty
As I was working on another PR (#41308) on Project DocType, github action show me this for semgreg failed result
Split method copy_from_template into two methods
copy_from_template_data
: for project_type and default expected_start_date to today, call on before_insert and validatecopy_from_template_task
: for tasks call on validate and after_insert