refactor(new_sc_flow_2): Fixed error thrown by semgrep

frappe · Dec 16, 2024 · da37e29 · da37e29
1 parent 080cd0c
commit da37e29
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -1,5 +1,5 @@
 exclude: 'node_modules|.git'
-default_stages: [pre-commit]
+default_stages: [commit]
 fail_fast: false
 
 

diff --git a/erpnext/subcontracting/doctype/subcontracting_order/subcontracting_order.py b/erpnext/subcontracting/doctype/subcontracting_order/subcontracting_order.py
@@ -157,8 +157,7 @@ def validate_service_items(self):
 
 		for service_item in self.service_items:
 			if frappe.get_value("Item", service_item.item_code, "is_stock_item"):
-				msg = f"Service Item {service_item.item_name} must be a non-stock item."
-				frappe.throw(_(msg))
+				frappe.throw(_("Service Item {0} must be a non-stock item.").format(service_item.item_code))
 
 			item = next(
 				item for item in self.items if item.purchase_order_item == service_item.purchase_order_item