s #1
Open
s #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankush
force-pushed
the
develop
branch
2 times, most recently
from
af0c5d0
to
cad9228
Compare
ankush
force-pushed
the
develop
branch
2 times, most recently
from
e6d8912
to
ae0edd8
Compare
ankush
force-pushed
the
develop
branch
2 times, most recently
from
caad677
to
6dda420
Compare
ci: use dynamic total job
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 7.81.1 to 7.119.1. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/7.119.1/CHANGELOG.md) - [Commits](getsentry/sentry-javascript@7.81.1...7.119.1) --- updated-dependencies: - dependency-name: "@sentry/browser" dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
…optimize imports in test_runner.py
…and extensibility
Test Runner improvements 1
* refactor: Improve readability and maintainability of main function * refactor: Simplify and optimize the run_all_tests function * refactor: simplify run_tests_for_doctype function * refactor: hint private methods * refactor: simplify _run_unittest function * refactor: simplify _add_test function * fix: Rename `iterate_suite` to `_iterate_suite`
* refactor: simplify print_mandatory_fields function * refactor: Encapsulate test record log functionality into a class * refactor: Simplify and consolidate make_test_records_for_doctype function
* refactor: use pathlib for file operations * feat: Add caching to get_dependencies and get_modules functions
* feat: Improve logging in test runner * feat: Categorize tests as unit or integration * feat: Add support for selecting test categories * feat: Split unit and integration tests execution * test: better output on cli runner * feat: Create TestRunner class * feat: Implement run method in TestRunner class * refactor: Refactor test discovery and execution in TestRunner class * feat: Integrate _run_doctype_tests functionality into TestRunner class * feat: Integrate _run_unittest functionality into TestRunner class * refactor: Handle distinction between loading specific test case and entire module * feat: Add handling of test dependencies in _add_module_tests method * refactor: Merge _add_tests into discover_tests * feat: Improve test results printing with click * refactor: wrap in proper error handling * fix: some signatures * feat: Add debug logs to frappe/test_runner.py * refactor: Move before_tests hooks after test discovery * refactor: Use TestConfig instead of frappe.flags.skip_before_tests * refactor: Add skip_test_records to TestConfig and update calling sites * feat: Defer test record creation until after before_tests hooks * feat: Add app parameter to _run_doctype_tests and _run_module_tests * feat: Add --test-category option to run_tests command * refactor: Add explanatory comments for skipping before_tests hooks and test record creation callbacks for unit tests * feat: Add test category option to run_tests command * feat: Unify explanatory comments in _prepare_integration_tests * fix: wrap implicit db access in try-except block * fix: mark current site * fix: case counting
This reverts commit 583e4bf.
Because of large common prefix hash naming becomes "too sequential" when doing a lot of concurrent writes. I don't know a good tradeoff between both use cases: 1. Lots of reads - prefers large shared prefix. 2. Lots of writes - prefers small shared prefix. But as of now this punishes writes too badly in form of excessive locking. Until a better fix is found, it's better to keep it prefix free. --- A better fix would be a tradeoff of between these two: 1. Reads - temporal locality should result in spatial locality on disk. 2. Writes - temporal locality should NOT result in spatial locality. temporal locality = data inserted around same time spatial locality = data sits next to each other in DB pages. This can be achieved by adding a small request/job specific part to prefix so each concurrent request has it's own different locality when writing data.
… function - Created `send_notification_by_channel` method to handle notification sending by channel and make it easier to extend the channels with a new channel - Simplified `send` method by moving channel-based notification logic to the new function
fix(style): fix oauth authorisation page and standardise error responses
fix: misc UI issues
chore: update POT file
feat: add `sms_gateway_enabled` flag to bootinfo
* fix: French translations * fix: Spanish translations * fix: Arabic translations * fix: German translations * fix: Swedish translations * fix: Turkish translations * fix: Persian translations * fix: Bosnian translations * fix: Esperanto translations * fix: Hungarian translations * fix: Chinese Simplified translations * fix: Spanish translations * fix: Swedish translations * fix: Polish translations * fix: Russian translations * fix: Turkish translations * fix: Spanish translations * fix: Turkish translations * fix: German translations * fix: French translations * fix: Spanish translations * fix: Arabic translations * fix: German translations * fix: Swedish translations * fix: Turkish translations * fix: Persian translations * fix: Bosnian translations * fix: Esperanto translations * fix: Hungarian translations * fix: Chinese Simplified translations * fix: Polish translations * fix: Russian translations * fix: Persian translations * fix: French translations * fix: Spanish translations * fix: Arabic translations * fix: German translations * fix: Swedish translations * fix: Turkish translations * fix: Persian translations * fix: Bosnian translations * fix: Esperanto translations * fix: Hungarian translations * fix: Chinese Simplified translations * fix: Polish translations * fix: Russian translations * fix: Turkish translations * fix: Turkish translations * fix: Turkish translations * fix: Swedish translations * fix: Spanish translations * fix: Swedish translations
fix: translatability of boldened text
due to circular imports issues and me going out of my way to make it work 'cleanly', the previous backwards compatibility for FrappeTestCase unfortunately did not work on the manual cli test runner 'run-tests' While not generally not affecting CI (which is precedented by the framwork's best practices to use 'run-parallel-test'), this broke some manual developer workflows The restauration of FrappeTestCase in these scenario now unfortunately involves a plain copy of almost an entire implementation into the dumpster. On the one hand, this doesn not accurately reflect the rather minuscule differences between IntegrationTestCase and FrappeTestCase, but on the other hand, it shields and freezes the old api should IntegrationTestCase evolve futher
* fix: Newsletter scheduling * fix: Newsletter scheduling
…s added Mismerge in 0d3b249 Thanks Revant for pointing it out Signed-off-by: Akhil Narang <[email protected]>
fix(new-site): `mariadb_user_host_login_scope` has been broken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
s