Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ConcurrentModificationException mentioned in Issue #47 #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Since HashSet is not thread-safe, getting a Set from ConcurrentHashMa…
…p which is thread-safe.
  • Loading branch information
Greg Williams committed Nov 3, 2017
commit fbba0350da40865f7bd3dc005911eebbbcb645e8
Original file line number Diff line number Diff line change
@@ -17,9 +17,10 @@
package com.franmontiel.persistentcookiejar.cache;

import java.util.Collection;
import java.util.HashSet;
import java.util.Collections;
import java.util.Iterator;
import java.util.Set;
import java.util.concurrent.ConcurrentHashMap;

import okhttp3.Cookie;

@@ -28,7 +29,7 @@ public class SetCookieCache implements CookieCache {
private Set<IdentifiableCookie> cookies;

public SetCookieCache() {
cookies = new HashSet<>();
cookies = Collections.newSetFromMap(new ConcurrentHashMap<IdentifiableCookie, Boolean>());
}

@Override