Fix missing PKCE field #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
king-jam
force-pushed
the
pkce
branch
2 times, most recently
from
3752662
to
54f51cb
Compare
frankie567
requested changes
Feb 5, 2024
There was a problem hiding this comment.
Makes total sense @king-jam, thank you 👏 I've added a few minor comments :)
docs/oauth2.md
Outdated
| @@ -29,6 +29,8 @@ Returns the authorization URL where you should redirect the user to ask for thei | |||
| * `redirect_uri: str`: Your callback URI where the user will be redirected after the service prompt. | |||
| * `state: str = None`: Optional string that will be returned back in the callback parameters to allow you to retrieve state information. | |||
| * `scope: Optional[List[str]] = None`: Optional list of scopes to ask for. | |||
| * `code_challenge: Optional[str] = None`: Optional code_challenge in a [PKCE context](https://datatracker.ietf.org/doc/html/rfc7636). | |||
| * `code_challenge_method: ptional[str] = None`: Optional code_challenge_method in a [PKCE context](https://datatracker.ietf.org/doc/html/rfc7636). | |||
httpx_oauth/oauth2.py
Outdated
| @@ -100,6 +100,8 @@ async def get_authorization_url( | |||
| redirect_uri: str, | |||
| state: Optional[str] = None, | |||
| scope: Optional[List[str]] = None, | |||
| code_challenge: Optional[str] = None, | |||
| code_challenge_method: Optional[str] = None, | |||
There was a problem hiding this comment.
Could you we type it as Literal['plain', 'S256']?
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #321 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 486 490 +4
=========================================
+ Hits 486 490 +4 ☔ View full report in Codecov by Sentry. |
|
Thank you @king-jam 🙏 @all-contributors add @king-jam for code |
|
I've put up a pull request to add @king-jam! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PKCE support only had the code_verifier portion on the get_access_token method. While possible to use extras_params for this, PKCE is becoming more mainstream so making it a first class field.