Ensure getting real releases, only master branch, fix headers folder name #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures it'll always get a release with `"prerelease": false`, even if there's a newer prerelease Ensures the release will always be from the master branch (by name, not the strongest guarantee, but better than nothing) It also avoids saving the file to disk and by piping the output from `curl` directly to `tar` Add -L parameter to curl so it follows redirects (necessary for fetching the archive)
andrebrait
commented
Aug 14, 2020
Extract it while fetching, no need for a temporary file
andrebrait
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures it'll always get a release with
"prerelease": false, even if there's a newer prereleaseEnsures the release will always be from the master branch (by name, not the strongest guarantee, but better than nothing)
It also avoids saving the file to disk by piping the output from
curldirectly totarAdd -L parameter to curl so it follows redirects (necessary for fetching the archive).
I also renamed the
includesfolder toinclude, which is the standard way of naming the folders containing header files, and I got rid of the.root directory on the tar archive. Now installing it to the VitaSDK folder is just atar xz -C "${VITASDK}/arm-vita-eabi"and the headers will go into the right directory.