This repository has been archived by the owner on Aug 31, 2018. It is now read-only.
fix #131: Concurrency issue with CheckRedirect of DefaultClient #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vvelikodny thx for contributing. Have you run the tests before sending the PR? |
vvelikodny
force-pushed
the
master
branch
3 times, most recently
from
7027fe2
to
ae7a5b8
Compare
|
@marcosnils didn't sorry, I see issues, going to fix it. |
|
@marcosnils all tests passed now, let me know what do you think, thanks! |
|
@vvelikodny thx for the update. Is there a chan e you can add a new test for the bug you're fixing? This way we prevent future issues with this functionality |
|
@marcosnils ok, cure, I will add new test to cover it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think
Requestshould wraphttp.Client. We don't need globalDefaultClientat all. User should passhttp.Clientdirectly toRequestwhen create it or new http client will be created each request.