Bind this for closures (#4)

francislavoie · Nov 14, 2023 · fe60a93 · fe60a93
1 parent 433e4c3
commit fe60a93
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/[email protected]/extension.js b/[email protected]/extension.js
@@ -37,11 +37,11 @@ export default class VolumeScrollerExtension extends Extension {
 
     this.scroll_binding = this.panel.connect(
       "scroll-event",
-      this._handle_scroll
+      this._handle_scroll.bind(this)
     );
     this.sink_binding = this.controller.connect(
       "default-sink-changed",
-      this._handle_sink_change
+      this._handle_sink_change.bind(this)
     );
   }
 
@@ -81,7 +81,6 @@ export default class VolumeScrollerExtension extends Extension {
     this.sink.push_volume();
 
     this._show_volume(volume);
-
     return Clutter.EVENT_STOP;
   }
 

diff --git a/[email protected]/metadata.json b/[email protected]/metadata.json
@@ -8,5 +8,5 @@
   "url": "https://github.com/francislavoie/gnome-shell-volume-scroller",
   "uuid": "[email protected]",
   "settings-schema": "org.gnome.shell.extensions.volume-scroller",
-  "version": 12
+  "version": 13
 }