Problem: Output is not composable #196
Merged
+15
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: Start by enclosing them all in an attribute set.
Solution: Put the package itself and all its dependencies in racket-packages.
Solution: Wrap packages in makeExtensible, all references via self.
Solution: Move functions into 'lib' attribute.
Now that we are referring to them with 'self.name' we can skip the workaround. Packages like 2 '2d-lib' can be safely addressed now that we can have quotes around the name. Solution: Remove the '_' prefix, address attributes with a quoted string. We are banking on nobody ever calling a racket package 'lib', 'extend' or '__unfix__'. For the moment it holds.
Solution: Use makeExtensible. Closes fractalide#175 - Wrap all the dependencies in an attribute set. - Export that attribute set as an attribute of the package. - Wrap the attribute set in a function called with makeExtensible. - Move our functions into a sub-attribute 'lib', minimize collision. - Take the chance to rename attributes to names without a '_' prefix. Example: $ nix-build -A racket-packages.racket2nix error: attribute 'racket2nix' in selection path 'racket-packages.racket2nix' not found $ nix-build -A racket-packages.nix /nix/store/l5dnla8gjg04v7v4q8pzkqaxqgp0l8cd-racket-minimal-7.0-nix $ nix-build -E 'with import ./. {}; (racket-packages.extend (self: super: { racket2nix = self.nix.overrideRacketDerivation (oldAttrs: { pname = "racket2nix-stage1"; }); })).racket2nix' /nix/store/zqlpq7iqcbia8wqiv03v9nlfdl637wvf-racket-minimal-7.0-racket2nix-stage1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: Use makeExtensible.
Closes #175
Example: