Skip to content
This repository has been archived by the owner on Oct 22, 2020. It is now read-only.

Initial support for apache 2.4 #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kepi
Copy link

@kepi kepi commented Dec 4, 2015

Original apache-top doesn't work on apache 2.4 because of small
diferences in output. There is new table with thread listing on
top of output which cause troubles.

This initial support just ignore this table so everything works
in same way as in 2.2 and older.

@fr3nd
Copy link
Owner

fr3nd commented Dec 9, 2015

Hi and thanks for your pull request. It looks great.

However, when I try to run it and for some reason it fails to reach the server-status page, the script fails with the following error:

Traceback (most recent call last):
  File "./apache-top.py", line 437, in <module>
    stdscr.keypad(0)
NameError: name 'stdscr' is not defined

It should show an error message instead.

If you fix this little annoyance I'll merge it

Original apache-top doesn't work on apache 2.4 because of small
diferences in output. There is new table with thread listing on
top of output which cause troubles.

This initial support just ignore this table so everything works
in same way as in 2.2 and older.
@kepi
Copy link
Author

kepi commented Dec 9, 2015

Yeah, I'm no python master and not sure about how nested exception works :)

Fixed version pushed - I moved whole block to detect apache version before curses initialization which is anyway much better.

@fr3nd
Copy link
Owner

fr3nd commented Dec 11, 2015

I'm testing your changes with Apache 2.4.6 and I'm unable to make it work... What version did you test it with?

@kepi
Copy link
Author

kepi commented Dec 11, 2015

Version 2.4.10 and 2.2.21. Can you send me your status page so I can check what differences are?

@altmas5
Copy link
Collaborator

altmas5 commented Dec 12, 2015

Hi @kepi, thanks for the support.
I also got an error testing on Apache version 2.4.16:

ERROR parsing the data. Please, make sure you are alowed to read the server-status page and you have ExtendedStatus flag activated

This is the html code generated on my mod_status page: http://slexy.org/view/s206tCFDVO

@kepi
Copy link
Author

kepi commented Dec 14, 2015

@altmas5 i'm not able to reach slexy.org. Looks like it doesn't work. Can you upload it somewhere else?

@altmas5
Copy link
Collaborator

altmas5 commented Dec 15, 2015

Sorry @kepi,

Try with this one: http://pastebin.com/GYBsJ7UM

@kepi
Copy link
Author

kepi commented Jan 7, 2016

@altmas5 please turn ExtendedStatus On in your config. If you open file you provided me with on pastebin, you can see that on last line there is info you don't have it enabled. Apache-top is working only with extended status.

@fr3nd Can you please provide me with raw output from status page so I can fix this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants