-
Notifications
You must be signed in to change notification settings - Fork 20
Initial support for apache 2.4 #10
base: master
Are you sure you want to change the base?
Conversation
Hi and thanks for your pull request. It looks great. However, when I try to run it and for some reason it fails to reach the server-status page, the script fails with the following error:
It should show an error message instead. If you fix this little annoyance I'll merge it |
Original apache-top doesn't work on apache 2.4 because of small diferences in output. There is new table with thread listing on top of output which cause troubles. This initial support just ignore this table so everything works in same way as in 2.2 and older.
1c16d7e
to
bf5e34a
Compare
Yeah, I'm no python master and not sure about how nested exception works :) Fixed version pushed - I moved whole block to detect apache version before curses initialization which is anyway much better. |
I'm testing your changes with Apache 2.4.6 and I'm unable to make it work... What version did you test it with? |
Version 2.4.10 and 2.2.21. Can you send me your status page so I can check what differences are? |
Hi @kepi, thanks for the support.
This is the html code generated on my mod_status page: http://slexy.org/view/s206tCFDVO |
@altmas5 i'm not able to reach slexy.org. Looks like it doesn't work. Can you upload it somewhere else? |
Sorry @kepi, Try with this one: http://pastebin.com/GYBsJ7UM |
@altmas5 please turn ExtendedStatus On in your config. If you open file you provided me with on pastebin, you can see that on last line there is info you don't have it enabled. Apache-top is working only with extended status. @fr3nd Can you please provide me with raw output from status page so I can fix this? |
Original apache-top doesn't work on apache 2.4 because of small
diferences in output. There is new table with thread listing on
top of output which cause troubles.
This initial support just ignore this table so everything works
in same way as in 2.2 and older.