Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump alloy 0.6.4 #9280

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

chore(deps): bump alloy 0.6.4 #9280

wants to merge 30 commits into from

Conversation

yash-atreya
Copy link
Member

@yash-atreya yash-atreya commented Nov 7, 2024

Motivation

Closes #9239
Latest alloy 0.6.4

Solution

Bump to latest and address breaking changes

* fix: ui - use AnyRpcBlock
* fix: wallets - use PrimitveSig
@yash-atreya
Copy link
Member Author

Blocked by alloy-rs/alloy#1631

@yash-atreya yash-atreya added the T-blocked Type: blocked label Nov 7, 2024
@zerosnacks zerosnacks changed the title chore(deps): bump alloy 0.6.1 chore(deps): bump alloy 0.6.2 Nov 11, 2024
@yash-atreya yash-atreya removed the T-blocked Type: blocked label Nov 11, 2024
@yash-atreya yash-atreya self-assigned this Nov 11, 2024
@zerosnacks zerosnacks changed the title chore(deps): bump alloy 0.6.2 chore(deps): bump alloy 0.6.4 Nov 14, 2024
@yash-atreya yash-atreya marked this pull request as ready for review November 15, 2024 05:18
Comment on lines +572 to +573
"sha3Uncles": "0x1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347",
"miner": "0x0000000000000000000000000000000000000000",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks similar to #9324 in terms of a breaking change

Is there a way we can handle this elegantly?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can add aliases in alloy

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that would be beneficial, it makes sure that users are able to load older Anvil states

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we then add the gas limit too?

Copy link
Member

@zerosnacks zerosnacks Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we should, reopened #9324 to be closed by this one

deny.toml Outdated Show resolved Hide resolved
Co-authored-by: zerosnacks <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
3 participants