Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update runtime to node20 #39

Merged
merged 1 commit into from
Dec 9, 2023
Merged

chore: update runtime to node20 #39

merged 1 commit into from
Dec 9, 2023

Conversation

erikburt
Copy link
Contributor

@erikburt erikburt commented Oct 20, 2023

See #38 for more context/motivation.

Changes:

  1. Updated action runtime to node20
  2. npm ci
  3. npm run build - rebuilding dist using node 20.8.1
  4. Updated docs

Tested by running locally with node20: RUNNER_TEMP=/tmp INPUT_VERSION=nightly node dist/index.js

Output

❯ RUNNER_TEMP=/tmp INPUT_VERSION=nightly node dist/index.js
Downloading Foundry 'nightly' from: https://github.com/foundry-rs/foundry/releases/download/nightly/foundry_nightly_darwin_arm64.tar.gz
::debug::Downloading https://github.com/foundry-rs/foundry/releases/download/nightly/foundry_nightly_darwin_arm64.tar.gz
::debug::Destination /tmp/22dc5b3b-bd15-411c-8451-0c668ee46518
::debug::download complete
::debug::Extracting /tmp/22dc5b3b-bd15-411c-8451-0c668ee46518
::debug::Checking tar --version
::debug::bsdtar 3.5.3 - libarchive 3.5.3 zlib/1.2.11 liblzma/5.0.5 bz2lib/1.0.8
[command]/usr/bin/tar xz -C /tmp/78749109-7d11-42a1-ba5e-69f0877f36dd -f /tmp/22dc5b3b-bd15-411c-8451-0c668ee46518
::add-path::/tmp/78749109-7d11-42a1-ba5e-69f0877f36dd


Closes #38.

Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This modifies both the action.yml file and the readme file, so this should be correct. looping @onbjerg for a last check—we'd need to release a new version

Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm provided ci passes

@erikburt
Copy link
Contributor Author

erikburt commented Dec 6, 2023

Any updates :)

@onbjerg onbjerg merged commit eef83bf into foundry-rs:master Dec 9, 2023
1 check passed
@erikburt erikburt deleted the chore/update-node20 branch December 20, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade action to use node20
3 participants