First Backend Code Review #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pire after a given amount of time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This is the first PR for backend code review. All Backend API documentation is provided in the backend/ folder under the README.md.
Testing
Testing has mainly been a "create model, test feature" workflow. Once backend and frontend were connected, backend testing was done primarily through frontend forms and calls. Aside from that, all other forms of testing were done using Postman to manage API requests.
PR Checklist
My code adheres to the code standards outlined in the EngineeringDocs repo. If not, add an explanation for why it doesn't.
Didn't adhere to the variable naming conventions, and some files are indented using spaces and some are indented using tabs (consqeuence of following some tutorials).
I have selected at least one primary assignee for this PR. These people need to approve this PR for it to be merged.
I have selected any number of reviewers for this pull request. Reviewers are people who should know about the pull request, but whose sign-off is not a blocker to merging.
PR Dependencies