Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checking for 'value' != None before creating IWbemClass properties #1854

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Checking for 'value' != None before creating IWbemClass properties #1854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de289b4
Checking for 'value' != None before creating IWbemClass properties
gabrielg5 Nov 28, 2024
15560ab
wmiquery - printing exception stack trace only if error is not 'S_FALSE'
gabrielg5 Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions examples/wmiquery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,10 @@ def printReply(self, iEnum):
print('%s |' % record[key]['value'], end=' ')
print()
except Exception as e:
if logging.getLogger().level == logging.DEBUG:
import traceback
traceback.print_exc()
if str(e).find('S_FALSE') < 0:
if logging.getLogger().level == logging.DEBUG:
import traceback
traceback.print_exc()
raise
else:
break
Expand Down
2 changes: 1 addition & 1 deletion impacket/dcerpc/v5/dcom/wmi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2613,7 +2613,7 @@ def SpawnInstance(self):
def createProperties(self, properties):
for property in properties:
# Do we have an object property?
if properties[property]['type'] == CIM_TYPE_ENUM.CIM_TYPE_OBJECT.value:
if properties[property]['type'] == CIM_TYPE_ENUM.CIM_TYPE_OBJECT.value and properties[property]['value'] != None:
# Yes.. let's create an Object for it too
objRef = OBJREF_CUSTOM()
objRef['iid'] = self._iid
Expand Down