Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop python2 support in wmi.py and ese.py #1804

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NtAlexio2
Copy link
Contributor

@NtAlexio2 NtAlexio2 commented Sep 3, 2024

This PR adds ordereddict module to requirements in order to references here (wmi.py) and here (ese.py)


EDIT:
Since new recent versions of Impacket doesn't support Python2, we can safely remove ordereddict module referenced here (wmi.py) and here (ese.py)

Tip: ordereddict module needs manual installation.

@exploide
Copy link
Contributor

exploide commented Sep 3, 2024

Does this make sense? OrderedDict is part of the standard library since Python 2.7. I think the try-except compatibility import of the ordereddict package is only to support ancient Python < 2.7.

Given that setup.py lists impacket being compatible with Python 3.8+ only, I think it would make sense to drop the ordereddict compatibility import instead and just use from collections import OrderedDict everywhere.

@NtAlexio2
Copy link
Contributor Author

@exploide Thanks for reminder! I'll apply required changes and change title 👍

@NtAlexio2 NtAlexio2 changed the title add "ordereddict" to requirements.txt drop python2 support in wmi.py and ese.py Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants