Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go 1.22.5 is out: changing go-versions manually #54

Closed
wants to merge 2 commits into from
Closed

Conversation

ldemailly
Copy link
Member

@ldemailly ldemailly commented Jul 2, 2024

annoying neither docker hub nor setup-go have it, 3h later

so 1.22 + latest:true doesn't work

ref: actions/setup-go#407
ref: docker-library/official-images#17104
ref: fortio/fortio#950

@ldemailly ldemailly changed the title go 1.22.5 is out: changing 2 out of 3 go-versions to confirm it doesn't get latest otherwise go 1.22.5 is out: changing go-versions manually Jul 2, 2024
@ldemailly ldemailly requested a review from hhhapz July 2, 2024 22:33
@earl-warren
Copy link

Please merge.

@earl-warren
Copy link

Actually actions/go-versions#102 was opened minutes ago, this workaround may not be necessary for much longer.

@ldemailly
Copy link
Member Author

@earl-warren ? the issue is it seems to always take a while... and action/setup-go updates are not automated

also this is just "our" (fortio's) repo

@StefMa
Copy link

StefMa commented Jul 3, 2024

Wouldn't be using toolchain a solution to this problem? 🤔
Instead of updating the setup go action go version you would update the toolchain entry and go itself will take care of downloading the newest version? 🤔
Or do I miss something here?
What would be the downside of this approach?

@earl-warren
Copy link

Sorry for the noise... I mistook this repo for another 😊

@ldemailly
Copy link
Member Author

checked on the fortio PR actions, we now get 1.22.5 with the current setup, closing this

(in short waiting a day and eventually things work, we're lucky the cve isn't severe...)

@ldemailly ldemailly closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants