Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: proxy for telemetry #268

Merged
merged 3 commits into from
Aug 3, 2023
Merged

fix: proxy for telemetry #268

merged 3 commits into from
Aug 3, 2023

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented Aug 1, 2023

What does this PR do?

use got/proxy like other plugins/libraries

  • the appInsights url always 404s. I think that was historically counted as, "yep, we can reach it." Had to mess with got's retry/timeout mechanism to make that work.

side effects

  • updated sinon. 2 UT will error when trying to stub node:os module. Didn't seem like useful tests so they're out

What issues does this PR fix or reference?

forcedotcom/cli#1752
@W-12076335@

@mshanemc mshanemc changed the title Sm/proxy and got fix: proxy for telemetry Aug 1, 2023
WillieRuemmele
WillieRuemmele approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@WillieRuemmele WillieRuemmele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like the standard got + ProxyAgent

@WillieRuemmele WillieRuemmele merged commit 3ef9bc9 into main Aug 3, 2023
11 checks passed
@WillieRuemmele WillieRuemmele deleted the sm/proxy-and-got branch August 3, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillieRuemmele WillieRuemmele WillieRuemmele approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mshanemc @WillieRuemmele