feat: more source member fields #704
Conversation
| @@ -46,16 +46,16 @@ const isSpecialAuraXml = (filePath?: string): boolean => | |||
|
|
|||
| // things that never have SourceMembers | |||
| const excludedKeys = [ | |||
| 'AppMenu__Salesforce1', | |||
There was a problem hiding this comment.
I changed the key delimiter. I think this might help some of the tracking issues with namespaced metadata, though the API drops some namespaces, too and this won't fix that.
| 'IsNameObsolete', | ||
| 'RevisionCounter', | ||
| 'IsNewMember', | ||
| 'ChangedBy', |
There was a problem hiding this comment.
is an ID field, not a real lookup. And it's 15-char.
| ApexClass__MyClass: { | ||
| serverRevisionCounter: 3, | ||
| ApexClass###MyClass: { | ||
| RevisionCounter: 3, |
There was a problem hiding this comment.
since I added a few more fields from the server, it seemed a good time to use the SourceMember's fields directly instead of a "let's rename them all in the json file"
| @@ -206,16 +227,14 @@ export class RemoteSourceTrackingService { | |||
| // to sync the retrieved SourceMembers; meaning it will update the lastRetrievedFromServer | |||
| // field to the SourceMember's RevisionCounter, and update the serverMaxRevisionCounter | |||
| // to the highest RevisionCounter. | |||
| public async retrieveUpdates({ sync = false, cache = true } = {}): Promise<RemoteChangeElement[]> { | |||
There was a problem hiding this comment.
nothing was using this and this isn't a public API
| @@ -458,7 +466,7 @@ ${formatSourceMemberWarnings(outstandingSourceMembers)}` | |||
| const matchingKey = sourceMembers.get(key) | |||
| ? key | |||
| : getDecodedKeyIfSourceMembersHas({ sourceMembers, key, logger: this.logger }); | |||
| this.sourceMembers.set(matchingKey, sourceMember); | |||
| this.sourceMembers.set(matchingKey, { ...sourceMember, MemberName: decodeURIComponent(sourceMember.MemberName) }); | |||
There was a problem hiding this comment.
check the logic here: let's always use a decoded key; the get already checks for the encoded version if it doesn't find a match
There was a problem hiding this comment.
I think this should be safe, both functionally and performance.
| const conn = this.org.getConnection(); | ||
| const queryResult = await queryFn(conn, query); | ||
| await updateCacheWithUnknownUsers(conn, queryResult, this.userQueryCache); | ||
| const queryResultWithResolvedUsers = queryResult.map((member) => ({ |
There was a problem hiding this comment.
converting the userId to a real name; query only those we haven't already seen and cache to avoid next time
| } | ||
|
|
||
| private async write(): Promise<void> { | ||
| const lockResult = await lockInit(this.filePath); | ||
| await lockResult.writeAndUnlock( | ||
| JSON.stringify( | ||
| { | ||
| fileVersion: CURRENT_FILE_VERSION, |
There was a problem hiding this comment.
a fileVersion makes changes easier next time
What does this PR do?
new fields for getChanges (the RemoteChange type)
Makes no changes to the output of the CLI
previewcommands, but the additional fields might be useful there (ex: I want to only see my changes, sorting change in order or recency (revisionCounter) etc)The preview command is already doing some of this change type calculation.
Some of these fields will appear in the local tracking files, but no changes to existing fields are made.
xNUT failure is because PDR is asserting things about the tracking files that are changed as part of this PR. If approved, I'll write a change for that NUT