FIX (PMD): @W-15708421@: Read PMD results from outfile instead of stdout. #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfeingold35
commented
Jul 24, 2024
There was a problem hiding this comment.
yarn build makes these code format changes, and I'm sick of manually removing them so I'm adding them in this PR.
test/lib/pmd/PmdEngine.test.ts
Outdated
There was a problem hiding this comment.
I didn't add a net-new test, because this behavior is a little hard to reliably and permanently test for. I can try to do that if people would like, though.
jfeingold35
force-pushed
the
d/W-15708421
branch
from
cb5c1c0
to
a90c1e0
Compare
stephen-carter-at-sf
approved these changes
Jul 24, 2024
src/lib/pmd/PmdEngine.ts
Outdated
| this.logger.trace(`About to run PMD rules. Targets: ${targetPaths.length}, Selected rules: ${selectedRules}`); | ||
|
|
||
| const stdout = await (await PmdWrapper.create({ | ||
| await (await PmdWrapper.create({ |
There was a problem hiding this comment.
Does it make sense to put the stdout in as a trace log (if it is non-empty) instead of just dropping it? It might help with debugging purposes in the future.
There was a problem hiding this comment.
Good call. I'll do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #1439 .