Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: scratch creation partial success #1086

Merged
merged 5 commits into from
Jun 14, 2024
Merged

fix: scratch creation partial success #1086

merged 5 commits into from
Jun 14, 2024

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented Jun 14, 2024 •
edited
Loading

What does this PR do?

  • save the alias/default for the org BEFORE attempting settings deployment
  • deploy error after scratch org auth is done are considered 68 (partial success)

test is here: salesforcecli/plugin-org#1100

What issues does this PR fix or reference?

forcedotcom/cli#202
@W-14879553@

@mshanemc mshanemc requested a review from a team as a code owner June 14, 2024 13:33
@mshanemc mshanemc mentioned this pull request Jun 14, 2024
Merged
shetzel
shetzel previously approved these changes Jun 14, 2024
View reviewed changes
src/org/scratchOrgCreate.ts Outdated Show resolved Hide resolved
@shetzel shetzel merged commit d5f2555 into main Jun 14, 2024
72 of 73 checks passed
@shetzel shetzel deleted the sm/scratch-org-partial-complete branch June 14, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shetzel shetzel shetzel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mshanemc @shetzel @svc-cli-bot