Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mz/Update bundling workflow #1059

Merged
merged 4 commits into from
Apr 17, 2024
Merged

Mz/Update bundling workflow #1059

merged 4 commits into from
Apr 17, 2024

Conversation

mingxuanzhangsfdx
Copy link
Member

What does this PR do?

This PR updates the workflow that generates based on the compiled files under /lib. The bundle generating from /lib could consume the transformer changes.

What issues does this PR fix or reference?

@W-15492052@

peternhale
peternhale previously approved these changes Apr 16, 2024
let bundledEntryPoint = fs.readFileSync(filePath, 'utf8');

const searchString = /\$\{process\.cwd\(\)\}\$\{require\("path"\)\.sep\}lib/g;
const searchString = /\$\{process\.cwd\(\)\}\$\{require\("path"\)\.sep\}tmp-lib/g;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could use our constant here

@mshanemc mshanemc merged commit bf118f6 into main Apr 17, 2024
66 checks passed
@mshanemc mshanemc deleted the mz/W-15492052 branch April 17, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants