Skip to content

Commit

Permalink
chore: set the default node version in bundle publishing flow
Browse files Browse the repository at this point in the history
  • Loading branch information
mingxuanzhangsfdx committed Aug 12, 2024
1 parent 6124ca6 commit 09fc350
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/esbuild-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
ref: ${{ inputs.branch }}
- uses: actions/setup-node@v4
with:
node-version: ${{ inputs.nodeVersion }}
node-version: ${{ inputs.nodeVersion || 'lts/*' }}
registry-url: 'https://registry.npmjs.org'
cache: yarn
- uses: salesforcecli/github-workflows/.github/actions/yarnInstallWithRetries@main
Expand Down

3 comments on commit 09fc350

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - ubuntu-latest

Benchmark suite Current: 09fc350 Previous: dfe544e Ratio
Child logger creation 470394 ops/sec (±0.97%) 474768 ops/sec (±1.49%) 1.01
Logging a string on root logger 776371 ops/sec (±8.73%) 849856 ops/sec (±9.91%) 1.09
Logging an object on root logger 628784 ops/sec (±7.04%) 43033 ops/sec (±183.37%) 0.06843844627089749
Logging an object with a message on root logger 6522 ops/sec (±210.81%) 395711 ops/sec (±13.32%) 60.67
Logging an object with a redacted prop on root logger 432748 ops/sec (±8.07%) 510189 ops/sec (±7.00%) 1.18
Logging a nested 3-level object on root logger 380539 ops/sec (±8.30%) 19942 ops/sec (±186.13%) 0.05240461555845787

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Logger Benchmarks - ubuntu-latest'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 09fc350 Previous: dfe544e Ratio
Logging an object with a message on root logger 6522 ops/sec (±210.81%) 395711 ops/sec (±13.32%) 60.67

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - windows-latest

Benchmark suite Current: 09fc350 Previous: dfe544e Ratio
Child logger creation 328670 ops/sec (±0.69%) 327003 ops/sec (±0.76%) 0.99
Logging a string on root logger 765884 ops/sec (±6.46%) 782107 ops/sec (±5.50%) 1.02
Logging an object on root logger 577180 ops/sec (±5.96%) 531582 ops/sec (±22.69%) 0.92
Logging an object with a message on root logger 7153 ops/sec (±201.59%) 5686 ops/sec (±206.63%) 0.79
Logging an object with a redacted prop on root logger 441001 ops/sec (±11.42%) 468973 ops/sec (±9.51%) 1.06
Logging a nested 3-level object on root logger 343507 ops/sec (±4.86%) 321327 ops/sec (±4.64%) 0.94

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.