Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/main' into cd/bump-jsforce
Browse files Browse the repository at this point in the history
  • Loading branch information
cristiand391 committed Jul 31, 2024
2 parents 57371d6 + a319bb4 commit 07f6d83
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion .github/workflows/testCoreBundling.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ jobs:
matrix:
os: ['ubuntu-latest', 'windows-latest']
externalProjectGit:
- forcedotcom/salesforcedx-templates
- forcedotcom/salesforcedx-apex
with:
externalProjectGit: ${{ matrix.externalProjectGit }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/testExternalProjects.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ on:
workflow_call:
inputs:
externalProjectGit:
description: 'The url that will be cloned. This contains the tests you want to run. Ex: https://github.com/forcedotcom/templates'
description: 'The url that will be cloned. This contains the tests you want to run. Ex: https://github.com/forcedotcom/salesforcedx-apex'
type: string
required: true
nodeVersion:
Expand All @@ -29,7 +29,7 @@ on:
jobs:
external-test:
name: run tests
if: ${{ inputs.externalProjectGit == 'forcedotcom/salesforcedx-apex' || (inputs.externalProjectGit == 'forcedotcom/salesforcedx-templates' && inputs.os == 'ubuntu-latest') }}
if: ${{ inputs.externalProjectGit == 'forcedotcom/salesforcedx-apex' }}
runs-on: ${{ inputs.os }}
steps:
- name: Configure Git to handle long file paths on Windows
Expand Down

3 comments on commit 07f6d83

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - ubuntu-latest

Benchmark suite Current: 07f6d83 Previous: 7f11ab8 Ratio
Child logger creation 478348 ops/sec (±1.39%) 477448 ops/sec (±1.60%) 1.00
Logging a string on root logger 834814 ops/sec (±7.43%) 861771 ops/sec (±9.20%) 1.03
Logging an object on root logger 44327 ops/sec (±182.92%) 648557 ops/sec (±6.14%) 14.63
Logging an object with a message on root logger 447373 ops/sec (±8.26%) 13671 ops/sec (±188.90%) 0.030558393108211717
Logging an object with a redacted prop on root logger 509272 ops/sec (±6.34%) 526707 ops/sec (±9.21%) 1.03
Logging a nested 3-level object on root logger 17679 ops/sec (±187.26%) 22576 ops/sec (±185.31%) 1.28

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Logger Benchmarks - ubuntu-latest'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 07f6d83 Previous: 7f11ab8 Ratio
Logging an object on root logger 44327 ops/sec (±182.92%) 648557 ops/sec (±6.14%) 14.63

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - windows-latest

Benchmark suite Current: 07f6d83 Previous: 7f11ab8 Ratio
Child logger creation 324316 ops/sec (±0.73%) 307575 ops/sec (±1.53%) 0.95
Logging a string on root logger 794039 ops/sec (±6.03%) 724299 ops/sec (±6.74%) 0.91
Logging an object on root logger 601114 ops/sec (±6.81%) 571246 ops/sec (±5.94%) 0.95
Logging an object with a message on root logger 5194 ops/sec (±209.95%) 8846 ops/sec (±191.32%) 1.70
Logging an object with a redacted prop on root logger 509405 ops/sec (±6.12%) 469364 ops/sec (±5.74%) 0.92
Logging a nested 3-level object on root logger 316290 ops/sec (±5.60%) 322796 ops/sec (±5.88%) 1.02

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.