Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW (Extension) @W-16002080@ Add eslint support and additional parameters for the scan #95

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

jag-j
Copy link
Collaborator

@jag-j jag-j commented Jun 20, 2024

This PR does the following:

  • Adding eslint support to the VS Code Extension. We do this by adding eslint-lwc as the default engine that would be executed. Users can change this to eslint or eslint-typescript in the settings.
  • The list of engines to run is completely configurable and hence pmd can be removed if needed.
  • Exposes a “normalize severity” flag as a setting and when that is turned on, we normalize the severity similar to CLI. This flag is turned off by default.
  • Exposes a “category” flag as a setting that is empty by default and can be overridden to a value by the users. When set, only those category rules are scanned.

@jag-j jag-j requested review from stephen-carter-at-sf and jfeingold35 and removed request for stephen-carter-at-sf June 20, 2024 20:41
@jag-j jag-j marked this pull request as ready for review June 20, 2024 20:41
@jag-j jag-j merged commit 65596aa into dev Jun 20, 2024
13 checks passed
@jag-j jag-j deleted the jj/W-16002080 branch June 20, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants